OoT-Randomizer icon indicating copy to clipboard operation
OoT-Randomizer copied to clipboard

Include ocarina buttons on the path of time

Open fenhl opened this issue 1 year ago • 2 comments

We forgot to add the ocarina button items required to play Song of Time to the Door of Time goal, so they currently behave incorrectly with respect to the goal lock and appear on later goals such as path to the key. This PR fixes that.

fenhl avatar Apr 16 '24 22:04 fenhl

Shouldn't all items woth to get behind dot already be included in path of time? Unless I guess the code was only checking for ToT access, and then including everything you might need in the ToT itself separately... By including these items like you have done here I think it will mean that all reachable sot note items (and any items woth to reach any of those items without going adult) could end up on path of time. I kind of feel like the path of time goal might be a bit overzealous in including all copies of these items like this? But I'm not sure what to do about it...

r0bd0g avatar Apr 17 '24 02:04 r0bd0g

This has previously been discussed in #1529. The tl;dr is that:

  • We include all copies of the items required to play Song of Time in the goal for consistency with other item-based goals (e.g. tokens).
  • We check for access to the Temple of Time region, not Beyond Door of Time, so we can place a goal lock to enforce all copies of the required items being reachable before the Door of Time in AGR.

fenhl avatar Apr 17 '24 08:04 fenhl