vantage-ui-template icon indicating copy to clipboard operation
vantage-ui-template copied to clipboard

Improve Lighthouse score

Open adamlaz opened this issue 8 years ago • 2 comments

Bug Report

I'm not sure if this counts as a bug - but figured I'd open this issue to see if you all think worth having a discussion. I'm playing around with this starter app (it's great!), and decided to run it through Google's Lighthouse tool to see what it says. Turns out, there may be some low-hanging fruit to improve the baseline performance and demonstrate even more Angular best-practices in this quickstart.

Let me know if there's a better place to chat about this, or if you have any questions for me!

Steps to view results

  1. Load JSON from this Gist into the Lighthouse viewer

Steps to test it yourself

The easiest way is to use the chrome extension.

  1. Install the Lighthouse chrome extension
  2. Go to the Covalent Quickstart App or your local version of the quickstart.
  3. Generate a report with the extension.

apr-08-2017 23-24-57

adamlaz avatar Apr 09 '17 06:04 adamlaz

This is great. Adding a manifest.json file to the assets shouldn't be too hard. I'd also like to see the quickstart show how to use lazy loading. That would require some refactoring of the modules. An initial service worker implementation would be cool too.

aciccarello avatar Apr 11 '17 17:04 aciccarello

There a LOT of things we can improve in the quickstart and promote best practices in everything. 😄

Hopefully we can tackle each one of those in separate smaller PR's.

emoralesb05 avatar Apr 11 '17 18:04 emoralesb05