api icon indicating copy to clipboard operation
api copied to clipboard

What should we do with ServerName value in /etc/httpd/conf.d/tendrl.conf?

Open mbukatov opened this issue 8 years ago • 2 comments

Right now, we have a ServerName defined with the following default value along with this comment in /etc/httpd/conf.d/tendrl.conf:

<VirtualHost *:80>
  # Adjust the ServerName directive to reflect the FQDN for your host. Add
  # additional ServerAlias directives if required.
  ServerName tendrl

Could we check this again while keeping the fact that this is the default configuration provided by tendrl-api-httpd package (required for both api and web interface) in mind and chose one of:

  • dropping the ServerName completely (it's optional), using automatic deduction instead
  • updating the documentation here to reflect changes needed
  • keeping some default value, while not asking admin to change it neither in the docs in the comment in the file itself

I'm not sure which option would make most sense in our case, but it could be a bit misleading that on one hand our rpm installation docs doesn't mention this, and on the other hand in the default config file, we have a suggestion to change the value.

Affected versions

tendrl-api-httpd-1.4.2-1.el7.centos.noarch

mbukatov avatar Jun 23 '17 17:06 mbukatov

@anivargi please respond to this

r0h4n avatar Aug 08 '17 05:08 r0h4n

This should be addressed along with https://github.com/Tendrl/tendrl-ansible/issues/30 (SSL setup), so that there are no error prone unnecessary differences between http and https setup.

mbukatov avatar Sep 26 '17 15:09 mbukatov