rapidjson icon indicating copy to clipboard operation
rapidjson copied to clipboard
verified publisher icon Tencent

Fix potential integer overflow

Open djbn65 opened this issue 6 months ago • 7 comments

This change fixes a potential integrer overflow due to assuming that unsigned is 4 bytes when there is no guarantee that unsigned types have a size of 4 bytes. The minimum required size is 2 bytes. Replace unsigned with uint32_t in GenericReader::ParseNumber to fix this issue.

djbn65 avatar Oct 22 '25 17:10 djbn65

CLA assistant check
All committers have signed the CLA.

tencent-adm avatar Oct 22 '25 17:10 tencent-adm

I think this may address #2289 which mentions https://nvd.nist.gov/vuln/detail/CVE-2024-39684. Not 100% certain, but couldn't find a better fix.

djbn65 avatar Oct 22 '25 17:10 djbn65

Fixes #2289

djbn65 avatar Oct 22 '25 17:10 djbn65

@miloyip, @tencent-adm, hoping we can get this in to fix the CVE

djbn65 avatar Oct 22 '25 17:10 djbn65

Fixes #2303

djbn65 avatar Oct 22 '25 17:10 djbn65

Hi @djbn65, why is this fix not merged to the master yet? I can see here that the CLA has been signed, is there any other blocker?

yukta-saneja avatar Nov 25 '25 04:11 yukta-saneja

Hi @djbn65, why is this fix not merged to the master yet? I can see here that the CLA has been signed, is there any other blocker?

Hey, @yukta-saneja, I do not have permissions to submit the change. Only the owners can accept the pull request and it seems they are not very responsive or even maintaining this repo anymore. I've tried emailing the owners but have gotten no response.

djbn65 avatar Nov 25 '25 20:11 djbn65