react-modal-sheet icon indicating copy to clipboard operation
react-modal-sheet copied to clipboard

`draggableAt` is Not Working

Open anliting opened this issue 1 year ago • 2 comments

draggableAt of the following example does not work on my device: https://github.com/Temzasse/react-modal-sheet/blob/HEAD/example/components/ScrollableSnapPoints.tsx https://temzasse.github.io/react-modal-sheet/#/scrollable-snap-points

What I expected is that, when the content is scrolled to top, the sheet is draggable.

anliting avatar Jul 26 '24 03:07 anliting

did you manage to have a workaround ?

shivaluma avatar Oct 08 '24 18:10 shivaluma

did you manage to have a workaround ?

No, I did not.

anliting avatar Oct 09 '24 07:10 anliting

This is pretty annoying. The drag action is only working on web browser when no device view is applied. Thinking of create a fork just to fix that problem and others already opened on pull requests.

carlos-ribeiro-zup avatar Oct 25 '24 20:10 carlos-ribeiro-zup

Hey everybody! 👋🏻

Chiming in here: the draggability is not super reliable on non-touch devices and I recommend testing it with a iOS/Android simulator instead of in Chrome's mobile emulation mode.

@carlos-ribeiro-zup I'm very much open to PRs to improve the draggability/scrollability 😊

Temzasse avatar Oct 27 '24 11:10 Temzasse

Thanks for replying @Temzasse. As the issues and PRs were opened too many days ago, I thought you've kind abandoned the lib. Glad it's not, cuz you did a really nice job here.

carlos-ribeiro-zup avatar Oct 27 '24 14:10 carlos-ribeiro-zup

Thanks @carlos-ribeiro-zup 👍🏻

I haven't abandoned the lib but I'm definitely much more busy nowadays so it's hard to find time to work on open source stuff 😞 Every now and then I get an energy boost and try to tackle multiple issues at once 😄

Temzasse avatar Oct 27 '24 14:10 Temzasse

Anyone working on a fix for this yet? just ran into it as well.

alexkates avatar Nov 13 '24 14:11 alexkates

Anyone working on a fix for this yet? just ran into it as well.

As @Temzasse have mentioned here.

This issue could be closed.

carlos-ribeiro-zup avatar Nov 13 '24 15:11 carlos-ribeiro-zup

You're right. Confirming after testing https://temzasse.github.io/react-modal-sheet/#/scrollable-snap-points on my iPhone simulator that it works as intended. Thanks!

alexkates avatar Nov 13 '24 16:11 alexkates

After testing, I found that it works perfectly on iOS, but not on Android. I had to use vaul as an alternative solution.

shivaluma avatar Nov 13 '24 16:11 shivaluma

Closing this as non-issue. If there are problems on Android that should be tracked in a separate issue.

Temzasse avatar Dec 27 '24 11:12 Temzasse