bGUI icon indicating copy to clipboard operation
bGUI copied to clipboard
verified publisher icon Temechon

bug fix: pick invalid mesh

Open jiexx opened this issue 10 years ago • 4 comments

bug fix: if there are more mesh picked, GUISystem.enableClick() will result in all mesh be picked. in actually, GUISystem.enableClick should pick only 2D bGUI mesh.

jiexx avatar Sep 29 '15 07:09 jiexx

commit e8ae08b0a1548a035eba1c42585fdfe334b719c8 Author: unknown [email protected] Date: Tue Sep 29 14:50:44 2015 +0800

bug fix: if there are more mesh picked, GUISystem.enableClick() will
result in all mesh be picked. in actually, GUISystem.enableClick should
pick only 2D bGUI mesh.

diff --git a/dist/bGUI-1.3.0.js b/dist/bGUI-1.3.0.js index 8f3b586..62fc407 100644 --- a/dist/bGUI-1.3.0.js +++ b/dist/bGUI-1.3.0.js @@ -98,7 +98,7 @@ var bGUI = bGUI || {}; @@ -98,7 +98,7 @@ var bGUI = bGUI || {}; }; _this._scene._updatePointerPosition(evt); var pickResult = _this._scene.pick(_this._scene._pointerX, _this._scene._pointerY, predicate, false, _this.getCamera());

  •        if (pickResult.hit) {
     };
     _this._scene._updatePointerPosition(evt);
     var pickResult = _this._scene.pick(_this._scene._pointerX, _this._scene._pointerY, predicate, false, _this.getCamera());

  •        if (pickResult.hit) {

  •        if (pickResult.hit && _this.getObjectByName(pickResult.pickedMesh.name) != null) {
         if (pickResult.pickedMesh.actionManager) {
             pickResult.pickedMesh.actionManager.processTrigger(BABYLON.ActionManager.OnPickTrigger, BABYLON.ActionEvent.CreateNew(pickResult.pic                 }
    @@ -110,7 +110,7 @@ var bGUI = bGUI || {}; }; _this._scene._updatePointerPosition(evt); var pickResult = _this._scene.pick(_this._scene._pointerX, _this._scene._pointerY, predicate, false, _this.getCamera());
  •        if (pickResult.hit) {

  •        if (pickResult.hit && _this.getObjectByName(pickResult.pickedMesh.name) != null) {
         if (pickResult.pickedMesh.actionManager) {
             pickResult.pickedMesh.actionManager.processTrigger(BABYLON.ActionManager.OnPickUpTrigger, BABYLON.ActionEvent.CreateNew(pickResult.p                 }
    diff --git a/src/GUISystem.js b/src/GUISystem.js index 6383fa8..ec7eba0 100644 --- a/src/GUISystem.js +++ b/src/GUISystem.js @@ -154,7 +154,7 @@ var bGUI = bGUI || {}; }; _this._scene._updatePointerPosition(evt); var pickResult = _this._scene.pick(_this._scene._pointerX, _this._scene._pointerY, predicate, false, _this.getCamera());
  •        if (pickResult.hit) {

  •        if (pickResult.hit && _this.getObjectByName(pickResult.pickedMesh.name) != null) {^M
         if (pickResult.pickedMesh.actionManager) {
             pickResult.pickedMesh.actionManager.processTrigger(BABYLON.ActionManager.OnPickTrigger, BABYLON.ActionEvent.CreateNew(pickResult.pic                 }
    @@ -167,7 +167,7 @@ var bGUI = bGUI || {}; }; _this._scene._updatePointerPosition(evt); var pickResult = _this._scene.pick(_this._scene._pointerX, _this._scene._pointerY, predicate, false, _this.getCamera());
  •        if (pickResult.hit) {

  •        if (pickResult.hit && _this.getObjectByName(pickResult.pickedMesh.name) != null) {^M
         if (pickResult.pickedMesh.actionManager) {
         }

jiexx avatar Sep 29 '15 07:09 jiexx

this will fix it

jiexx avatar Sep 29 '15 07:09 jiexx

Thank you Jiexx. Is it possible for you to do a pull request for this ? Thanks :)

Kimoen avatar Sep 30 '15 09:09 Kimoen

i want to access pickResult.pickedMesh.index & pickResult.pickedMesh.picked value but unable to do it..??

any one can help? plz

ghost avatar Jul 22 '18 10:07 ghost