AdapterJS icon indicating copy to clipboard operation
AdapterJS copied to clipboard

reloading OSX Safari 7.1 Mavericks after a call using Temasys plugin fails

Open JamieMcDonnell opened this issue 11 years ago • 13 comments

Hi there,

another one I'm afraid - it seems consistent after ending a call in Safari OSX Mavricks using your plugin, if I try to reload the page to make another call the page fails to reload. I have to kill safari and open it again to be able to reload the page and make another call.

Please let me know if you need any more details in how to reproduce this issue.

Thanks

Jamie

JamieMcDonnell avatar Nov 10 '14 08:11 JamieMcDonnell

ok, it doesn't seem to happen every time I reload the page after a successful call, but perhaps about 50% of the time.

JamieMcDonnell avatar Nov 10 '14 08:11 JamieMcDonnell

hi Jamie,

thank you for the feedback.

Would you have a test webpage we could use to try to reproduce the problem?

Alex.

On Mon, Nov 10, 2014 at 4:35 PM, JamieMcDonnell [email protected] wrote:

ok, it doesn't seem to happen every time I reload the page after a successful call, but perhaps about 50% of the time.

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62354761.

Alex. Gouaillard, PhD, PhD, MBA

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

sg.linkedin.com/agouaillard

agouaillard avatar Nov 10 '14 21:11 agouaillard

We have a dev platform you can call me on to see the issue for yourself, though on there is my workaround for the problem so the rest of the team can test and use dev.

I can comment out the issue temporarily while you investigate it, but not for too long as we have testing and development to continue with on dev this morning.

Thanks

Jamie

On Mon Nov 10 2014 at 10:10:02 PM alex gouaillard [email protected] wrote:

hi Jamie,

thank you for the feedback.

Would you have a test webpage we could use to try to reproduce the problem?

Alex.

On Mon, Nov 10, 2014 at 4:35 PM, JamieMcDonnell [email protected]

wrote:

ok, it doesn't seem to happen every time I reload the page after a successful call, but perhaps about 50% of the time.

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62354761.

Alex. Gouaillard, PhD, PhD, MBA

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

sg.linkedin.com/agouaillard

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62455557.

JamieMcDonnell avatar Nov 11 '14 08:11 JamieMcDonnell

JO,

Please give it a try ASAP.

Alex.

On Tue, Nov 11, 2014 at 4:21 PM, JamieMcDonnell [email protected] wrote:

We have a dev platform you can call me on to see the issue for yourself, though on there is my workaround for the problem so the rest of the team can test and use dev.

I can comment out the issue temporarily while you investigate it, but not for too long as we have testing and development to continue with on dev this morning.

Thanks

Jamie

On Mon Nov 10 2014 at 10:10:02 PM alex gouaillard < [email protected]> wrote:

hi Jamie,

thank you for the feedback.

Would you have a test webpage we could use to try to reproduce the problem?

Alex.

On Mon, Nov 10, 2014 at 4:35 PM, JamieMcDonnell < [email protected]>

wrote:

ok, it doesn't seem to happen every time I reload the page after a successful call, but perhaps about 50% of the time.

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62354761.

Alex. Gouaillard, PhD, PhD, MBA


CTO - Temasys Communications, S'pore / Mountain View President - CoSMo Software, Cambridge, MA


sg.linkedin.com/agouaillard

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62455557.

— Reply to this email directly or view it on GitHub https://github.com/Temasys/AdapterJS/issues/23#issuecomment-62515560.

Alex. Gouaillard, PhD, PhD, MBA

CTO - Temasys Communications, S'pore / Mountain View

President - CoSMo Software, Cambridge, MA

sg.linkedin.com/agouaillard

agouaillard avatar Nov 11 '14 18:11 agouaillard

Hi,

My personal tests don't show this issue. Let me contact you by email so I can have a look at your application code.

J-O

johache avatar Nov 12 '14 01:11 johache

Hi, I confirm that (at least in my case) the plugin freezes Safari (Mavericks) once close() is called in the RTCPeerConnection. I will be able to provide an HTML soon.

ibc avatar Dec 29 '14 00:12 ibc

NOTE: I do not even need to establish a session with a peer, but just create a RTCPeerConnection, attach it the local MediaStream and then call pc.close().

ibc avatar Dec 29 '14 00:12 ibc

The fact is that it does not crash on PC.close() but when calling it and also MediaStream.close(). You can check it here:

http://rtcninja.aliax.net/

Just click Start, Stop, and Start again (it is already frozen). Stop basically does:

pcA.close();
pcA.close();
localMediaStream.close()

(localMediaStream is the object retrieved via getUserMedia())

ibc avatar Dec 30 '14 23:12 ibc

Alright, I was able to reproduce the issue. I'll open a new ticket on this.

johache avatar Jan 05 '15 07:01 johache

Hey Iñaki,

I believe I fixed the issue on my side; However, when I tried with you application, the issue had disappear with both my locally built plugin and the released one (0.8.810)

Did you change your code base?

johache avatar Jan 30 '15 04:01 johache

Yes, I removed the "closeMediaStream(localStream") once the PeerConnection is closed. I've re-enabled it and yes, it freezes Safari.

ibc avatar Jan 30 '15 13:01 ibc

FYI, I tested against our current internal build and the issue was gone. A new version including this fix should be released next week.

johache avatar Jun 30 '15 09:06 johache

2015-06-30 11:22 GMT+02:00 Jacques-Olivier Haché [email protected]:

FYI, I tested against our current internal build and the issue was gone. A new version including this fix should be released next week.

Thanks!

Iñaki Baz Castillo [email protected]

ibc avatar Jun 30 '15 15:06 ibc