Telegram-iOS icon indicating copy to clipboard operation
Telegram-iOS copied to clipboard

When app is locked with passcode, you can see through lock screen during device rotation

Open G-200 opened this issue 3 years ago • 2 comments

Checklist

  • [x] I am reporting an issue in existing functionality that does not work as intended
  • [x] I've searched for existing GitHub issues

Description

When app is locked with passcode and gradient background is used (which is default), when rotating the device you can see what is hidden behind lock screen. It is hardly visible, but if you record screen video, you can see it during slow playback.

Expected Behavior

You should not see anything through lock screen.

Actual Behavior

You can see what is behind lock screen, for example chat list.

Steps to Reproduce

  1. Turn on passcode
  2. Lock the app
  3. Rotate device

Environment

Device: iPhone/iPad X

iOS version: 16.3

App version: 9.3.2

G-200 avatar Jan 29 '23 20:01 G-200

If you will, I think it can be fixed by replacing this line:

https://github.com/TelegramMessenger/Telegram-iOS/blob/6a495f84c6bef56b554526218b26795fc0e15488/submodules/PasscodeUI/Sources/PasscodeEntryControllerNode.swift#L207

with:

if let background = self.background, background.size == size || background.makeBackgroundNode() is GradientBackgroundNode {

G-200 avatar Jan 29 '23 20:01 G-200

@ali-fareed Can you please look into this? It seems like a security issue. It is still not fixed in 9.4.3.

G-200 avatar Feb 19 '23 18:02 G-200