mistica-web
mistica-web copied to clipboard
FixedToTop
Current implementation
The ThemeContextProvider accepts to configure the dimensions of the NavigationBar:
dimensions: {
headerMobileHeight: number;
headerDesktopHeight: number;
};
But these dimensions are not being used by the NavigationBar component
There is a context named FixedToTop that allows to set the height of the elements that are being placed to the top (like a NavigationBar) but the NavigationBar component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:
https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51
Possible improvements
- The
NavigationBarcomponent should set its height according to thedimensionsvalue from the theme - The
NavigationBarcomponent should set theFixedToTopcontext value
comment from teams