TedGoas
RTL Fluid template
I just made a new template for RTL (right to left) languages such as Persian, Arabic, Urdu,... based on Fluid template.
Please take a look on it and if it is fine, I continue working on making RTL version of other templates as well.
@ahangarha Hey thanks for thinking about this. RTL is definitely something I'd like to support, but I have another idea of how to do it. Would love your thoughts.
I reviewed the first template you updated and from what I can tell, the change from the regular templates would be pretty minimal. Add a direction: rtl !important; to the CSS reset is what I saw, is there anything else I missed?
If possible, I'd rather not go from supporting three templates to six for a one or two line change. Maintaining the three templates is a manual process, so I'd love to keep the number of moving parts to a minimum.
Instead of adding more templates, I wonder if we could add instructions on how to change each template to RTL in the documentation. Perhaps something like this?
There was one kore change: margin of li elements.
This can be one approach. Let me see how we can make it in way that all changes be done inaide one file maybe by uncommenting some lines.
Give me little time to find the best way.
On سهشنبه ۵ فوریهٔ ۲۰۱۹، ۱۹:۵۹ Ted Goas [email protected] wrote:
@ahangarha https://github.com/ahangarha Hey thanks for thinking about this. RTL is definitely something I'd like to support, but I have another idea of how to do it. Would love your thoughts.
I reviewed the first template you updated and from what I can tell, the change from the regular templates would be pretty minimal. Add a direction: rtl !important; to the CSS reset is what I saw, is there anything else I missed?
If possible, I'd rather not go from supporting three templates to six for a one or two line change. Maintaining the three templates is a manual process, so I'd love to keep the number of moving parts to a minimum.
Instead of adding more templates, I wonder if we could add instructions on how to change each template to RTL in the documentation https://tedgoas.github.io/Cerberus/. Perhaps something like this? [image: screen shot 2019-02-05 at 11 27 26 am] https://user-images.githubusercontent.com/1172461/52287911-142ed900-2939-11e9-950d-c55915b1d27d.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TedGoas/Cerberus/pull/208#issuecomment-460704849, or mute the thread https://github.com/notifications/unsubscribe-auth/AKuHY2ygzebiOzPTldbG4d3OOdoNS8Qyks5vKbFPgaJpZM4agHaj .
Didn't find time to work on it. Keep the issue open. I will work for sure