VancedManager icon indicating copy to clipboard operation
VancedManager copied to clipboard

[Enhancement] Spotlight application download error in AppInstallDialog

Open cl-ement05 opened this issue 4 years ago • 2 comments

So I just tried to install Youtube Vanced without internet connection. Well although I knew my phone wasn't connected to the internet and that the download would fail, it took me some seconds to notice the error printed at the right bottom in a small font. Also, download progress bar is stuck at 0% and this does not help to notice there was an error.

I think this could be improved to better spotlight the fact that there was an error. The least (I believe) would be :

  • Stop showing the progress bar and its percentage because this leads to confusion/misunderstanding
  • Make the error message more visible i.e. bigger font size, center text in the dialog and maybe a color that better stands out of the grey background of the dialog

And, although sometimes this error is thrown for other reasons, showing a hint like "Check your internet connection and/or firewall" would be nice.

cl-ement05 avatar Apr 27 '21 14:04 cl-ement05

I might be able to do it and make a PR. But just to be sure, should I create a new dialog for this (something like AppDownloadErrorDialog) ? Or is there another way to do this ?

cl-ement05 avatar Apr 29 '21 08:04 cl-ement05

I might be able to do it and make a PR. But just to be sure, should I create a new dialog for this (something like AppDownloadErrorDialog) ? Or is there another way to do this ?

TBH I don't really see a point in making a PR since it'll all be migrated to Jetpack Compose anyways, it would be easier for me to do it, although, I really appreciate your willingness to help. Thanks

X1nto avatar Apr 29 '21 09:04 X1nto