Piped icon indicating copy to clipboard operation
Piped copied to clipboard

Piped not playing livestreams

Open hugoghx opened this issue 2 years ago • 5 comments

Official Instance

Describe the bug

When opening a livestream, the piped frontend just displays the spinning icon.

I noticed this 2 days ago after a frontend update. It's happening in piped.video too when playing a livestream. From the looks of it, it's some frontend problem as the proxy is replying with data but no playback occurs, and also I can watch the livestreams on the phone through Yattee.

I built the frontend from source, version master @ cc478fd5 and it now works. I suspect the shaka player update broke something.

To Reproduce

  1. Open livestream on piped.video
  2. Observe the spinning loading icon that does not go away - The livestream never loads.

Expected behavior

It should load and play.

Logs/Errors

No response

Browser, and OS with Version.

I tried on a variety of browsers (Firefox, Brave, Edge, Safari) and OSes (Windows, iOS)

Additional context

Whilst loading, there is network activity with the proxy.

hugoghx avatar Sep 03 '23 10:09 hugoghx

Same here (Firefox 115.2.0 / Win7), yet I have two Piped instances which render live streams correctly:

https://efy.piped.pages.dev/ : not included in Piped instances list https://piped.privacydev.net/ : included in Piped Instances list

Tested with several live streams, i.e. Euronews Live (EN and FR), Sky News Live, France 24 Live (EN and FR).

ghost avatar Sep 09 '23 09:09 ghost

I have isolated this problem to the shaka-player updates. Any version after 4.3.9 does not load livestreams, however, starting off of the current master branch and reverting the package to 4.3.9 restores the livestream functionality.

I'm unsure why updating the package leads to this behaviour.

hugoghx avatar Oct 17 '23 19:10 hugoghx

I have isolated this problem to the shaka-player updates. Any version after 4.3.9 does not load livestreams, however, starting off of the current master branch and reverting the package to 4.3.9 restores the livestream functionality.

I'm unsure why updating the package leads to this behaviour.

Would you happen to know how to revert shaka-player using docker compose?

maathimself avatar Oct 21 '23 00:10 maathimself

Would you happen to know how to revert shaka-player using docker compose?

I am also using docker compose to deploy software. What I did was clone this repo, then on the master branch, downgrade shaka-player to 4.3.9 here. Then, I used pnpm to update the lock file.

Here's a patch with the changes: shaka-player-downgrade.patch

Finally, I changed the Docker Compose service definition to build the image from my local piped repo (which we just made the changes to)

  piped:
    build:
      context: "<path/to/piped>"
      dockerfile: "Dockerfile"
    ...

instead of

  piped:
    image: "1337kavin/piped-frontend:latest"
    ...

From there, Docker builds the image and runs it. Keep in mind that now you will need to maintain this yourself. You won't get updates automatically from the upstream image, you need to actively pull the latest master, rebase your branch that has your downgrade commit off of the latest master (including dealing with conflicts), then re-build the image to update.

hugoghx avatar Oct 21 '23 09:10 hugoghx

The solution is currently not working, do you have any ideas for a solution?

Orygaw avatar Jan 04 '24 21:01 Orygaw