NewPipeExtractor icon indicating copy to clipboard operation
NewPipeExtractor copied to clipboard

Add support for AV1 itags.

Open FireMasterK opened this issue 4 years ago • 4 comments

  • [x] I carefully read the contribution guidelines and agree to them.
  • [ ] I have tested the API against NewPipe.
  • [ ] I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

I don't really like this approach, since this can include 60 fps streams as well as HDR streams... #488 is the ideal solution, but there's a lot of work to be done on the NewPipe app side which I know nothing about

Closes #672

FireMasterK avatar Aug 06 '21 20:08 FireMasterK

Tested this on a experimental branch with #488 in the NewPipe app. https://www.youtube.com/watch?v=kJQP7kiw5Fk worked fine (maybe a non AV1-codec was used - idk). However videos like https://www.youtube.com/watch?v=aqz-KE-bpKQ failed on higher resolutions (>1080p): grafik

See also https://github.com/TeamNewPipe/NewPipeExtractor/pull/488#issuecomment-904741877

TL;DR Would not recommend merging currently

litetex avatar Aug 24 '21 15:08 litetex

Discussion continued on https://github.com/TeamNewPipe/NewPipeExtractor/pull/488#issuecomment-904766848, this behavior happens on high-resolution WEBM and AV1 streams, and even HDR streams and is to be fixed on the App side, and not the extractor.

FireMasterK avatar Aug 24 '21 16:08 FireMasterK

Unfortunately that means until #488 is merged this won't be merged?

ghost avatar Aug 29 '21 18:08 ghost

Neither of these PRs can be merged currently as there is work to be done in the app to adapt for these changes.

FireMasterK avatar Aug 29 '21 19:08 FireMasterK

Android 14 will force the support of software AV1 decoding, even if the hardware does not support. Will you consider supporting it in NewPipe (hopefully) by the time Android 14 is released to general public?

ehyoitsdavid avatar Dec 21 '22 23:12 ehyoitsdavid

https://corp.mediatek.com/news-events/press-releases/mediatek-to-enable-cutting-edge-av1-video-codec-technology-on-android-smartphones

ag2s20150909 avatar Jun 15 '23 09:06 ag2s20150909