NewPipeExtractor icon indicating copy to clipboard operation
NewPipeExtractor copied to clipboard

Inconsistent 'empty' return values

Open wb9688 opened this issue 5 years ago • 0 comments

NewPipeExtractor has inconsistent return values in some places for when there is e.g. no HLS URL, i.e:

media.ccc.de

    @Nonnull
    @Override
    public String getHlsUrl() throws ParsingException {
        return null;
    }

PeerTube

    @Override
    public String getHlsUrl() throws ParsingException {
        return "";
    }

SoundCloud

    @Nonnull
    @Override
    public String getHlsUrl() throws ParsingException {
        return "";
    }

HLS URLs aren't the only case where that happens.

wb9688 avatar Mar 02 '20 12:03 wb9688