NewPipe icon indicating copy to clipboard operation
NewPipe copied to clipboard

Update AppCompat to 1.5.1 and compile SDK to 32

Open Isira-Seneviratne opened this issue 3 years ago • 2 comments

What is it?

  • [ ] Bugfix (user facing)
  • [ ] Feature (user facing)
  • [ ] Codebase improvement (dev facing)
  • [x] Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Update the AppCompat version to 1.5.1.
  • Update the compile SDK to 32.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

Isira-Seneviratne avatar Aug 13 '22 03:08 Isira-Seneviratne

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Sep 12 '22 07:09 sonarqubecloud[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Nov 01 '22 01:11 sonarqubecloud[bot]

@Isira-Seneviratne How have you been able to merge this without an approving review?

AudricV avatar Nov 07 '22 10:11 AudricV

@Isira-Seneviratne How have you been able to merge this without an approving review?

If I remember correctly, it was approved by @TobiGr .

Isira-Seneviratne avatar Nov 07 '22 10:11 Isira-Seneviratne

That could be true. If I remember correctly, I review this PR.

TobiGr avatar Nov 09 '22 15:11 TobiGr