graphix icon indicating copy to clipboard operation
graphix copied to clipboard

Secure pattern generation

Open masa10-f opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is.

Graphix does not guarantee the runnability and deterministic properties of a pattern when it is passed to a simulator or QPU. It would be beneficial if these fundamanetal properties are ensured during the pattern generation process.

Describe the feature you'd like A clear and concise description of what you want to happen.

One possible way to do this is to generate a pattern from the underlying graph and flowlike objects(including causal flow, gflow, and pauli flow). Flows can be understood as a feedforward protocol that ensures deterministic property of MBQC.

  1. Generalize the graph-based pattern generator(generator.generate_from_graph) with an arbitrary flowlike object(related to #120 )
  2. Generate every pattern through the above generator
  3. Implement flags in the pattern class such as pattern.is_deterministic and pattern.is_runnable.

I plan to refactor some methods in the pattern class to clarify which operations preserve the properties. For example, standardize and shift_signals preserve the properties, but add does not. I will implement a property-preserving pattern concatenation method for those who want to directly edit the pattern.

Additional context Add any other context or screenshots about the feature request here.

masa10-f avatar Jul 31 '24 23:07 masa10-f

That's something we have in mind and will do soon. The easiest way seems to check we don't offend runnability when adding a command without reference to the graph and whether it has flow.

mgarnier59 avatar Aug 01 '24 07:08 mgarnier59

I don't grasp how to do that and its generality. So please let me discuss after your team's PR submitted.

Anyway, I have implemented the above features in another repo. So I will submit a PR soon after finishing circuit PR.

masa10-f avatar Aug 01 '24 09:08 masa10-f