graphix icon indicating copy to clipboard operation
graphix copied to clipboard

Setup Ruff

Open EarlMilktea opened this issue 1 year ago • 2 comments

Description of the change:

Setup Ruff linter CI.

Related issue:

Resolves #140

EarlMilktea avatar May 07 '24 02:05 EarlMilktea

~~@EarlMilkTea let us merge this after #135~~

shinich1 avatar May 09 '24 04:05 shinich1

Codecov Report

Attention: Patch coverage is 77.63158% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 71.96%. Comparing base (2a032e4) to head (944f32f).

Files Patch % Lines
graphix/pattern.py 47.05% 9 Missing :warning:
graphix/device_interface.py 0.00% 3 Missing :warning:
graphix/visualization.py 0.00% 2 Missing :warning:
graphix/extraction.py 66.66% 1 Missing :warning:
graphix/graphsim/graphstate.py 0.00% 1 Missing :warning:
graphix/graphsim/nxgraphstate.py 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   71.91%   71.96%   +0.04%     
==========================================
  Files          30       30              
  Lines        5359     5350       -9     
==========================================
- Hits         3854     3850       -4     
+ Misses       1505     1500       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 09 '24 04:05 codecov[bot]

~@EarlMilktea let us merge this after #135~

@thierry-martinez @shinich1 is not planning to merge this PR immediately. Could you wait a while until everything is ready?

EarlMilktea avatar May 22 '24 22:05 EarlMilktea

Ruff config. is partly merged by #135 .

@shinich1

How about migrating from black + isort to Ruff format?

Ruff provides almost the same features and is faster. Additionally we can simplify pyproject.toml .

MEMO: Not planning to merge this PR. I'm planning to abandon it.

EarlMilktea avatar Jun 23 '24 18:06 EarlMilktea