TeamAmaze
Fix navigation buttons barely visible on dark and light mode
Description
This PR addresses the issue where navigation buttons are barely visible on Motorola devices when using the White/Day theme. The visibility issue is caused by the navigation bar color blending with the background, making the buttons hard to see.
Issue tracker
Fixes #3535
Automatic tests
- [x] Added test cases
Manual tests
- [x] Done
hi @Thejas775, happy to see your interest in contributing to amaze! but, the approach you used was not the expected solution. currently, you are changig the BG color of nav bar. the issue is to change the colors of nav icons. can you try whether something like this this works?
Okay sure.
@Thejas775 any updates here?
Hey, sorry I was busy with something. I tried the way described in the stackoverflow but it didn't work
I tried the way described in the stackoverflow but it didn't work
oh, I have tried those when I was reviewing your PR & they worked, IIRC. you can push your changes -- I will take a look.
I tried the way described in the stackoverflow but it didn't work
oh, I have tried those when I was reviewing your PR & they worked, IIRC. you can push your changes -- I will take a look.
Which one to push the new one from stack overflow?
@Thejas775 Um... Yep, the one you were facing issues with -- the one that didn't work.
hi Thejas, is this still being worked upon? can I take this PR over?
Hey sorry, I was busy with something. Please take over this PR.
-
removed code from
MainActivity&AboutActivitysince it was redundant. both of them inheritThemedActivity& the same was done there too. -
removed setting the nav bar colors since the default android colors were better than the ones we set + they were the cause of this issue leading to usability issues too.