virtual icon indicating copy to clipboard operation
virtual copied to clipboard

Total size is calculated incorrectly for masonry grids

Open yekta opened this issue 1 year ago • 1 comments

Describe the bug

I'm using @tanstack/svelte-virtual. With masonry type grids total size (.getTotalSize()) seems to be based on all other row heights + the height of the shortest item in the last row of the grid (instead tallest item in the latest row of the grid).

Expected behavior

For masonry type grids .getTotalSize() being calculated based on tallest item in each row instead of shortest item for the very last row.

Platform

macOS, Chrome

tanstack-virtual version

v3.0.4

Terms & Code of Conduct

  • [X] I agree to follow this project's Code of Conduct
  • [X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

yekta avatar Feb 08 '24 07:02 yekta

Think it is fixed already in February. Installed latest version, and it is working correctly.

davx1992 avatar May 16 '24 14:05 davx1992