No rows returned by useVirtualizer in unit tests

[densk1]

Describe the bug

In browser table rows are rendered as expected. In unit tests useVirtualizer returns an empty array from rowVirtualizer.getVirtualItems(). The bug is introduce with changes introduced by v3.0.0-beta.63. It also exists in the latest release v3.0.1

I think it was introduced by #598 here

Your minimal, reproducible example

below

Steps to reproduce

This unit test will pass for v3.0.0-beta.62 and fail for any version there after.

import { useVirtualizer } from "@tanstack/react-virtual";
import { render, screen } from "@testing-library/react";
import { styled } from "@mui/material";
import { useCallback, useRef } from "react";

const items = [
  { id: 1, name: "foo" },
  { id: 2, name: "bar" },
];

const Parent = styled("div")({ height: "100%", width: "100%", overflow: "auto" });

const Inner = styled("div")({ width: "100%", position: "relative" });

const Row = styled("div")({ position: "absolute", top: 0, left: 0, width: "100%" });

function VirtualTableComponent() {
  const parentRef = useRef<HTMLDivElement>(null);

  const rowVirtualizer = useVirtualizer({
    count: items.length,
    getScrollElement: () => parentRef.current,
    estimateSize: useCallback(() => 56, []),
  });

  return (
    <Parent ref={parentRef}>
      <Inner sx={{ height: `${rowVirtualizer.getTotalSize()}px` }}> {/* set at 112px as expected */}
        {rowVirtualizer.getVirtualItems().map((virtualRow) => ( // always an empty array
          <Row
            key={virtualRow.index}
            data-index={virtualRow.index}
            ref={rowVirtualizer.measureElement}
            style={{ transform: `translateY(${virtualRow.start}px)` }}
          >
            <div>{items[virtualRow.index].name}</div>
          </Row>
        ))}
      </Inner>
    </Parent>
  );
}

describe("@tanstack/react-virtual", () => {
  it("renders rows", () => {
    render(<VirtualTableComponent />);

    expect(screen.getByText(items[0].name)).toBeInTheDocument();
    expect(screen.getByText(items[1].name)).toBeInTheDocument();
  });
});

Expected behavior

As a user I expect the provided unit test to pass but it fails.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

macOS

tanstack-virtual version

v3.0.1

TypeScript version

v4.9.5

Additional context

I've console.log'd out the value of rowVirtualizer.getTotalSize() and it is given 112 as expected

Terms & Code of Conduct

• [X] I agree to follow this project's Code of Conduct
• [X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

[niteeshkd]

@ryansavino @fitzthum @fidencio

[fidencio]

@niteeshkd, does it require any change in the QEMU command line used to create the VM?

[niteeshkd]

does it require any change in the QEMU command line used to create the VM?

It does not require change in the kata shim to create the SNP coco. If we need to handle the attestation, we will have to modify the shim which we will handle later.

[fidencio]

I'll leave the review for those more familiar with those changes, and if an ack is needed from my side, I'll add after they do the review. Thanks @niteeshkd!

[niteeshkd]

Btw @niteeshkd will this new QEMU still function on the old non-UPM SNP Kernel? If not we should probably also add a note to the coco docs.

No, this qemu on non-UPM kernel does not work. Here is the error it reports.

$ sudo journalctl -xeu containerd
...
 Feb 13 18:41:04 amdmilan1 kata[4163390]: time="2024-02-13T18:41:04.079527912Z" level=error msg="qemu-system-x86_64: vm-type snp not supported by KVM"

[fitzthum]

No, this qemu on non-UPM kernel does not work. Here is the error it reports.

Ok, we'll just have to be clear that we have a change of host requirements for the next release. Slightly inconvenient, but I think this upgrade is fairly important.

[fitzthum]

Also @zvonkok might be interested in this?

[fidencio]

No, this qemu on non-UPM kernel does not work. Here is the error it reports.

Please, add this to the commit message. :-)

[ryansavino]

/test

[niteeshkd]

Fixed building of qemu-snp-experimental using tools/packaging/kata-deploy/local-build/kata-deploy-binaries.sh .

[fidencio]

/test