table icon indicating copy to clipboard operation
table copied to clipboard

Fix an issue where pageIndex becomes invalid when data is changed (removed) and autoResetPageIndex is false.

Open hamidvirani opened this issue 2 years ago • 6 comments

This fixes issue #4994

The pageIndex now gets set to correct value, if invalid, when autoResetPageIndex is false and data changes

hamidvirani avatar Aug 19 '23 15:08 hamidvirani

I like this! I have to get around it with an useEffect in my tanstack table code bases like this:

https://github.com/KevinVandy/mantine-react-table/blob/433b24f761e10e4268039763479e8b415286334f/packages/mantine-react-table/src/hooks/useMRT_Effects.ts#L50

Will look into merging this fix

KevinVandy avatar Aug 22 '23 01:08 KevinVandy

Hi,

Do you think this PR can be merged?

hamidvirani avatar Oct 27 '23 00:10 hamidvirani

Any news on when this will be merged?

I am hoping to get this working to release app to production. This is a blocker if pagination does not reset when the last row is deleted in the last page and the table does not reset to the previous page.

Please help.

p-viral avatar Jan 11 '24 19:01 p-viral

Any news on when this will be merged?

I am hoping to get this working to release app to production. This is a blocker if pagination does not reset when the last row is deleted in the last page and the table does not reset to the previous page.

Please help.

You can always just do this with your own code. Any fix here would just be a quality of life update.

KevinVandy avatar Mar 19 '24 19:03 KevinVandy

@KevinVandy I have resolved the conflicts if we want to merge this PR

hamidvirani avatar Mar 19 '24 23:03 hamidvirani