table icon indicating copy to clipboard operation
table copied to clipboard

Fix: getCanGroup always resolving to true

Open mozzerbob opened this issue 2 years ago • 2 comments

Small update to getCanGroup. It would always resolve to true and ignore the rest of the statement.

Fixing issue #4809.

mozzerbob avatar May 08 '23 20:05 mozzerbob

@mozzerbob i can see the fix above, im using "@tanstack/react-table": "^8.10.3", and still having this issue. has this fix been released? @KevinVandy i noticed you have this option in your materialTable, how did you get it to work correctly?

step2341 avatar Dec 04 '23 02:12 step2341

@mozzerbob i can see the fix above, im using "@tanstack/react-table": "^8.10.3", and still having this issue. has this fix been released? @KevinVandy i noticed you have this option in your materialTable, how did you get it to work correctly?

It never got merged, its waiting for a maintainer approval.

mozzerbob avatar Dec 13 '23 08:12 mozzerbob

Is it possible to get this merged? This function always returns true, even when enableGrouping is false.

tannera-cargill avatar Mar 11 '24 18:03 tannera-cargill

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b33ce23170a96cb023030f8bb700878444a67f57. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Mar 29 '24 05:03 nx-cloud[bot]