refactor: integrate util "noop" function in each packages
I integrated util function "noop". The function "noop" is already made in "query-core" package. So, we don't need to make again in "react-query" package
View your CI Pipeline Execution β for commit 0e1ae6963d927c7c177f8f7b73b54eb25834338b
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
β Succeeded | 1m 33s | View β |
nx run-many --target=build --exclude=examples/*... |
β Succeeded | 4s | View β |
βοΈ Nx Cloud last updated this comment at 2025-08-31 06:36:49 UTC
More templates
- @tanstack/query-example-angular-auto-refetching
- @tanstack/query-example-angular-basic
- @tanstack/query-example-angular-basic-persister
- @tanstack/query-example-angular-devtools-panel
- @tanstack/query-example-angular-infinite-query-with-max-pages
- @tanstack/query-example-angular-optimistic-updates
- @tanstack/query-example-angular-pagination
- @tanstack/query-example-angular-query-options-from-a-service
- @tanstack/query-example-angular-router
- @tanstack/query-example-angular-rxjs
- @tanstack/query-example-angular-simple
- @tanstack/query-example-react-algolia
- @tanstack/query-example-react-auto-refetching
- @tanstack/query-example-react-basic
- @tanstack/query-example-react-basic-graphql-request
- @tanstack/query-example-chat
- @tanstack/query-example-react-default-query-function
- @tanstack/query-example-react-devtools-panel
- @tanstack/query-example-eslint-legacy
- @tanstack/query-example-react-infinite-query-with-max-pages
- @tanstack/query-example-react-load-more-infinite-scroll
- @tanstack/query-example-react-nextjs
- @tanstack/query-example-react-nextjs-app-prefetching
- @tanstack/query-example-nextjs-suspense-streaming
- @tanstack/query-example-react-offline
- @tanstack/query-example-react-optimistic-updates-cache
- @tanstack/query-example-react-optimistic-updates-ui
- @tanstack/query-example-react-pagination
- @tanstack/query-example-react-playground
- @tanstack/query-example-react-prefetching
- @tanstack/query-example-react-react-native
- @tanstack/query-example-react-router
- @tanstack/query-example-react-rick-morty
- @tanstack/query-example-react-shadow-dom
- @tanstack/query-example-react-simple
- @tanstack/query-example-react-star-wars
- @tanstack/query-example-react-suspense
- @tanstack/query-example-solid-astro
- @tanstack/query-example-solid-basic
- @tanstack/query-example-solid-basic-graphql-request
- @tanstack/query-example-solid-default-query-function
- @tanstack/query-example-solid-simple
- @tanstack/query-example-solid-start-streaming
- @tanstack/query-example-svelte-auto-refetching
- @tanstack/query-example-svelte-basic
- @tanstack/query-example-svelte-load-more-infinite-scroll
- @tanstack/query-example-svelte-optimistic-updates
- @tanstack/query-example-svelte-playground
- @tanstack/query-example-svelte-simple
- @tanstack/query-example-svelte-ssr
- @tanstack/query-example-svelte-star-wars
- @tanstack/query-example-vue-2.6-basic
- @tanstack/query-example-vue-2.7-basic
- @tanstack/query-example-vue-basic
- @tanstack/query-example-vue-dependent-queries
- @tanstack/query-example-vue-nuxt3
- @tanstack/query-example-vue-persister
- @tanstack/query-example-vue-simple
@tanstack/angular-query-devtools-experimental
npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9125
@tanstack/angular-query-experimental
npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9125
@tanstack/eslint-plugin-query
npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9125
@tanstack/query-async-storage-persister
npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9125
@tanstack/query-broadcast-client-experimental
npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9125
@tanstack/query-core
npm i https://pkg.pr.new/@tanstack/query-core@9125
@tanstack/query-devtools
npm i https://pkg.pr.new/@tanstack/query-devtools@9125
@tanstack/query-persist-client-core
npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9125
@tanstack/query-sync-storage-persister
npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9125
@tanstack/react-query
npm i https://pkg.pr.new/@tanstack/react-query@9125
@tanstack/react-query-devtools
npm i https://pkg.pr.new/@tanstack/react-query-devtools@9125
@tanstack/react-query-next-experimental
npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9125
@tanstack/react-query-persist-client
npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9125
@tanstack/solid-query
npm i https://pkg.pr.new/@tanstack/solid-query@9125
@tanstack/solid-query-devtools
npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9125
@tanstack/solid-query-persist-client
npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9125
@tanstack/svelte-query
npm i https://pkg.pr.new/@tanstack/svelte-query@9125
@tanstack/svelte-query-devtools
npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9125
@tanstack/svelte-query-persist-client
npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9125
@tanstack/vue-query
npm i https://pkg.pr.new/@tanstack/vue-query@9125
@tanstack/vue-query-devtools
npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9125
commit: 0e1ae69
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 86.84%. Comparing base (379670d) to head (0e1ae69).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9125 +/- ##
===========================================
+ Coverage 45.17% 86.84% +41.66%
===========================================
Files 208 1 -207
Lines 8327 38 -8289
Branches 1886 10 -1876
===========================================
- Hits 3762 33 -3729
+ Misses 4118 5 -4113
+ Partials 447 0 -447
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Walkthrough
The changeset centralizes usage of a noop utility by importing it from @tanstack/query-core across multiple packages, removing local noop implementations. One package version is bumped. Minor typing is added for an unsubscribe variable. No control flow or public API signatures are altered.
Changes
| Cohort / File(s) | Summary of edits |
|---|---|
Angular Query Experimentalpackages/angular-query-experimental/src/inject-mutation.ts, packages/angular-query-experimental/src/providers.ts, packages/angular-query-experimental/src/util/index.ts |
Switch noop import to @tanstack/query-core; remove local noop export/usage; delete util/index.ts noop export. |
Solid Querypackages/solid-query/src/useMutation.ts, packages/solid-query/src/useQueries.ts, packages/solid-query/src/utils.ts |
Import noop from core; remove local noop export; add explicit type (() => void) to unsubscribe initialization. |
Svelte Querypackages/svelte-query/src/createBaseQuery.ts, packages/svelte-query/src/createMutation.ts, packages/svelte-query/src/createQueries.ts, packages/svelte-query/src/utils.ts |
Import noop from core and drop from local utils; keep isSvelteStore import; remove local noop export. |
Sync Storage Persisterpackages/query-sync-storage-persister/src/index.ts, packages/query-sync-storage-persister/src/utils.ts |
Change noop import to core; delete local noop declarations and implementation. |
Async Storage Persister (metadata)packages/query-async-storage-persister/package.json |
Bump version 5.76.0 β 5.85.5; no code changes. |
Estimated code review effort
π― 2 (Simple) | β±οΈ ~10 minutes
Poem
I tidied my burrow, hop by hop,
Gathering noops into one cozy shop.
Local echoes hushed, the core now sings,
Version bumps flutter on gentle wings.
With whiskers twitching, I press βmergeβ β plop! πβ¨
[!TIP]
π Remote MCP (Model Context Protocol) integration is now available!
Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.
π Recent review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
π‘ Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
π₯ Commits
Reviewing files that changed from the base of the PR and between 2d5a9a82759221520da2587837aeb3b22d301ae2 and d1c98bf61b61340140d3f92541bb1b77afeec092.
π Files selected for processing (1)
-
packages/query-async-storage-persister/package.json(1 hunks)
β Files skipped from review due to trivial changes (1)
- packages/query-async-storage-persister/package.json
β° Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
β¨ Finishing Touches
π§ͺ Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignoreor@coderabbit ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.