As PR is a bit stuck, this PR implements the same, with respect to the comments left in the first PR. Fix https://github.com/TanStack/query/issues/6954

Aug 27 '24 14:08 Efimenko

@TkDodo Also, currently, after the second fetch, the error will be maximum call stack size exceeded. So, probably, we need to check if the data is serializable or not, rather than wait call stack size exceeded. Inside replaceEqualDeep, some kind of:

try {
  JSON.stringify(data)
} catch {
  throw new Error('Data is not serializable')
}

Aug 27 '24 14:08 Efimenko

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 82d75b75dbd6f19a8ec2e7646a4c7e59680c0430. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Aug 27 '24 15:08 nx-cloud[bot]

commit: 82d75b7

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7966

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7966

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7966

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7966

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7966

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7966

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7966

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7966

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7966

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7966

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7966

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7966

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7966

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7966

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7966

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7966

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7966

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7966

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7966

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7966

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7966

Open in Stackblitz

More templates

Aug 27 '24 15:08 pkg-pr-new[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.36%. Comparing base (82bfc34) to head (82d75b7). Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7966       +/-   ##
===========================================
+ Coverage   45.09%   63.36%   +18.26%     
===========================================
  Files         188      127       -61     
  Lines        7149     4545     -2604     
  Branches     1604     1267      -337     
===========================================
- Hits         3224     2880      -344     
+ Misses       3562     1437     -2125     
+ Partials      363      228      -135

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`86.58% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`92.87% <100.00%> (+0.04%)`	:arrow_up:
@tanstack/query-devtools	`5.24% <ø> (ø)`
@tanstack/query-persist-client-core	`57.73% <ø> (ø)`
@tanstack/query-sync-storage-persister	`82.50% <ø> (ø)`
@tanstack/react-query	`92.50% <ø> (ø)`
@tanstack/react-query-devtools	`10.71% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.20% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`87.33% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.42% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

Aug 30 '24 10:08 codecov[bot]

fix(query-core): handle errors that occur inside `setData` method

☁️ Nx Cloud Report

Codecov Report