query icon indicating copy to clipboard operation
query copied to clipboard

fix(query-core): add error management around this.setData(data)

Open robin4a4 opened this issue 1 year ago • 2 comments

This aim to fix #6954. I am not sure that the test perfectly reproduces the initial issue as I am really new to this code base but it was failing before the try catch and seems to pass after the fix.

robin4a4 avatar Jun 28 '24 19:06 robin4a4

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 7:40pm

vercel[bot] avatar Jun 28 '24 19:06 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3277657a67afcef46fbb70423dea666d5d453615:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Jun 28 '24 19:06 codesandbox-ci[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b4edd38cc1f4ee54b78c3d48fc1a1550ccadfb9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jul 21 '24 23:07 nx-cloud[bot]

commit: 8b4edd3

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7642
pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7642
pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7642
pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7642
pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7642
pnpm add https://pkg.pr.new/@tanstack/query-core@7642
pnpm add https://pkg.pr.new/@tanstack/query-devtools@7642
pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7642
pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7642
pnpm add https://pkg.pr.new/@tanstack/react-query@7642
pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7642
pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7642
pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7642
pnpm add https://pkg.pr.new/@tanstack/solid-query@7642
pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7642
pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7642
pnpm add https://pkg.pr.new/@tanstack/svelte-query@7642
pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7642
pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7642
pnpm add https://pkg.pr.new/@tanstack/vue-query@7642
pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7642

Open in Stackblitz

More templates

pkg-pr-new[bot] avatar Jul 21 '24 23:07 pkg-pr-new[bot]

some types are not quite right with your mocks, which is why the pipeline fails

TkDodo avatar Jul 26 '24 11:07 TkDodo

superseded by:

  • https://github.com/TanStack/query/pull/7966

TkDodo avatar Aug 27 '24 15:08 TkDodo