ensure enabled as getter receives query param, remove unnecessary guard following v5.48.0 changes in query-core

Jun 26 '24 03:06 il-1337

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
query	⬜️ Ignored (Inspect)			Jun 26, 2024 3:42am

Jun 26 '24 03:06 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 678416dbdb93b29c7e09c2c91aca56a8248a6ab6:

Sandbox	Source
@tanstack/query-example-angular-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration
@tanstack/query-example-solid-basic-typescript	Configuration
@tanstack/query-example-svelte-basic	Configuration
@tanstack/query-example-vue-basic	Configuration

Jun 26 '24 03:06 codesandbox-ci[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e8555f3e89be965398dd61f483d7b8783745e404. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
`nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3`

✅ Successfully ran 1 target

nx run-many --target=build --exclude=examples/** --exclude=integrations/**

Sent with 💌 from NxCloud.

Jun 26 '24 21:06 nx-cloud[bot]

This would not work in a reactive way, unless you add all dependencies used in enabled callback into the queryKey.

And since getter on enabled in Vue was introduced mostly to reactively enable/disable query, i'm not sure if we want to break this assumption.

Jun 26 '24 21:06 DamianOsipiuk

Run & review this pull request in StackBlitz Codeflow.

commit: e8555f3

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7625

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7625

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7625

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7625

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7625

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7625

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7625

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7625

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7625

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7625

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7625

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7625

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7625

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7625

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7625

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7625

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7625

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7625

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7625

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7625

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7625

templates

Jul 18 '24 00:07 pkg-pr-new[bot]

fix(vue-query): remove unnecessary enabled guard

☁️ Nx Cloud Report