query icon indicating copy to clipboard operation
query copied to clipboard

Refactor(utils): Ensure consistent declaration style of utility functions and standardize parameters for the sleep method

Open Lennon57 opened this issue 1 year ago • 4 comments

I noticed that most functions within the packages/*/src/utils.ts and packages/*/src/__tests__/utils.ts files were declared as regular functions, so I made consistent adjustments. While most were already in this format, I found a few arrow functions and updated them accordingly (It doesn't seem to be using the 'this"). Additionally, I noticed inconsistency in the parameters of the sleep function, where some used timeout while others used ms, so I unified them all to ms.

Lennon57 avatar Jun 11 '24 15:06 Lennon57

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 3:16pm

vercel[bot] avatar Jun 11 '24 15:06 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 87306cb5ca1ab916e7650c5fde4de0ace30865a1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jun 11 '24 15:06 nx-cloud[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87306cb5ca1ab916e7650c5fde4de0ace30865a1:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Jun 11 '24 15:06 codesandbox-ci[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.25%. Comparing base (96a743e) to head (87306cb). Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7554       +/-   ##
===========================================
+ Coverage   43.87%   62.25%   +18.38%     
===========================================
  Files         184      124       -60     
  Lines        7027     4478     -2549     
  Branches     1534     1233      -301     
===========================================
- Hits         3083     2788      -295     
+ Misses       3578     1459     -2119     
+ Partials      366      231      -135     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 86.58% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 92.78% <100.00%> (-0.01%) :arrow_down:
@tanstack/query-devtools 5.24% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 82.50% <ø> (ø)
@tanstack/react-query 92.72% <ø> (ø)
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.06% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 68.66% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 70.60% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

codecov[bot] avatar Jun 11 '24 15:06 codecov[bot]