query icon indicating copy to clipboard operation
query copied to clipboard

fix(query-core): widen QueriesObserver queries type (#7446)

Open yannickcr opened this issue 1 year ago • 4 comments

Widen the QueriesObserver queries type so we can assign UseQueryOptions to QueryObserverOptions.

The result from the queryOptions helper can now be passed to QueriesObserver.

This align the QueriesObserver behavior with QueryObserver (that already accepts UseQueryOptions).

Caveat: The return type from QueriesObserver will be QueriesObserver<QueryObserverResult[]>, it means that the QueryObserverResult data type will be unknown. As discussed in https://github.com/TanStack/query/issues/7446#issuecomment-2120125066 it has been decided that it was an acceptable compromise for now.

yannickcr avatar May 29 '24 13:05 yannickcr

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Jun 7, 2024 3:09pm

vercel[bot] avatar May 29 '24 13:05 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f741903212e37d4beca147975f70e812850ad99:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar May 29 '24 13:05 codesandbox-ci[bot]

can you add a type test for your situation please?

TkDodo avatar May 31 '24 13:05 TkDodo

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 05e887d42f446494160b96ce173e963e3cac22cd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 31 '24 13:05 nx-cloud[bot]

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 05e887d

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7492
@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@7492
@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@7492
@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@7492
@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7492
@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@7492
@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@7492
@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@7492
@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@7492
@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@7492
@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@7492
@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@7492
@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@7492
@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@7492
@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@7492
@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@7492
@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@7492
@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@7492
@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@7492
@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@7492
@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@7492

templates

pkg-pr-new[bot] avatar Jul 17 '24 14:07 pkg-pr-new[bot]

prettier fails now 😭

TkDodo avatar Jul 17 '24 14:07 TkDodo