query icon indicating copy to clipboard operation
query copied to clipboard

fix(svelte-query): createQueries type

Open ap0nia opened this issue 1 year ago • 2 comments

CreateQueryOptions.queryFn should be a union between SkipToken and QueryFunction.

The GetResults type in react-query seems to handle this, but svelte-query currently omits this union, so the QueriesResult type always returns QueryObserverResult[] even if the query options are strongly typed/defined.

ap0nia avatar May 14 '24 17:05 ap0nia

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 0:33am

vercel[bot] avatar May 14 '24 17:05 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d16c04f685dae99b31a68e885858c30bdf085f7:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar May 14 '24 17:05 codesandbox-ci[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3d16c04f685dae99b31a68e885858c30bdf085f7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar May 15 '24 20:05 nx-cloud[bot]