query icon indicating copy to clipboard operation
query copied to clipboard

eslint-plugin-query is incompatible with Eslint 9.x

Open yotamselementor opened this issue 1 year ago • 3 comments

Describe the bug

eslint-plugin-query has a peer dependency for eslint 8. When I try to upgrade my project to use eslint 9, npm install fails due to peer dependency mismatch.

Thanks!

Your minimal, reproducible example

Any NodeJS project

Steps to reproduce

  1. npm i -D @tanstack/[email protected]
  2. npm i -D [email protected] Erroneous output:
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^7.0.0 || ^8.0.0" from @typescript-eslint/[email protected]
npm ERR!   node_modules/@tanstack/eslint-plugin-query/node_modules/@typescript-eslint/utils
npm ERR!     @typescript-eslint/utils@"^6.20.0" from @tanstack/[email protected]
npm ERR!     node_modules/@tanstack/eslint-plugin-query
npm ERR!       dev @tanstack/eslint-plugin-query@"^5.28.11" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-import@"*" from [email protected]
npm ERR! node_modules/eslint-import-resolver-typescript
npm ERR!   dev eslint-import-resolver-typescript@"^3.6.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/eslint
npm ERR!   peer eslint@"^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8" from [email protected]
npm ERR!   node_modules/eslint-plugin-import
npm ERR!     peer eslint-plugin-import@"*" from [email protected]
npm ERR!     node_modules/eslint-import-resolver-typescript
npm ERR!       dev eslint-import-resolver-typescript@"^3.6.1" from the root project

Expected behavior

Installation should be smooth :)

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

all

Tanstack Query adapter

None

TanStack Query version

5.28.11

TypeScript version

No response

Additional context

No response

yotamselementor avatar Apr 16 '24 07:04 yotamselementor

Is there a technical reason why this support has not been added so long after the eslint 9 release?

ffaubert avatar Apr 30 '24 22:04 ffaubert

Adding relevant links here: https://github.com/TanStack/query/pull/7253 https://github.com/typescript-eslint/typescript-eslint/issues/8211

yotamselementor avatar May 06 '24 09:05 yotamselementor

It gives me a headache. I ran into a problem with these configs a year ago. Nothing has changed...

DaiFudo avatar May 08 '24 04:05 DaiFudo