query icon indicating copy to clipboard operation
query copied to clipboard

fix(angular-query): consistent injector parameter

Open arnoud-dv opened this issue 1 year ago β€’ 3 comments

Opted for an injector parameter for all inject* functions. An options object having an injector property might be preferable to easily add additional options in the future. But having two options objects (e.g. query options and additional options having the injector) would be confusing and the first options object should be consistent with other adapters.

arnoud-dv avatar Mar 30 '24 13:03 arnoud-dv

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Mar 30, 2024 1:32pm

vercel[bot] avatar Mar 30 '24 13:03 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8eb49f33f38ab0e88742c026ad7723110d01e4b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 1 target

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] avatar Mar 30 '24 13:03 nx-cloud[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8eb49f33f38ab0e88742c026ad7723110d01e4b9:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Mar 30 '24 13:03 codesandbox-ci[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (93674fe) to head (8eb49f3). Report is 396 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #7201       +/-   ##
==========================================
- Coverage   41.42%       0   -41.43%     
==========================================
  Files         184       0      -184     
  Lines        7331       0     -7331     
  Branches     1531       0     -1531     
==========================================
- Hits         3037       0     -3037     
+ Misses       3889       0     -3889     
+ Partials      405       0      -405     
Components Coverage Ξ”
@tanstack/angular-query-devtools-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/angular-query-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/eslint-plugin-query βˆ… <ΓΈ> (βˆ…)
@tanstack/query-async-storage-persister βˆ… <ΓΈ> (βˆ…)
@tanstack/query-broadcast-client-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/query-codemods βˆ… <ΓΈ> (βˆ…)
@tanstack/query-core βˆ… <ΓΈ> (βˆ…)
@tanstack/query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/query-persist-client-core βˆ… <ΓΈ> (βˆ…)
@tanstack/query-sync-storage-persister βˆ… <ΓΈ> (βˆ…)
@tanstack/react-query βˆ… <ΓΈ> (βˆ…)
@tanstack/react-query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/react-query-next-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/react-query-persist-client βˆ… <ΓΈ> (βˆ…)
@tanstack/solid-query βˆ… <ΓΈ> (βˆ…)
@tanstack/solid-query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/solid-query-persist-client βˆ… <ΓΈ> (βˆ…)
@tanstack/svelte-query βˆ… <ΓΈ> (βˆ…)
@tanstack/svelte-query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/svelte-query-persist-client βˆ… <ΓΈ> (βˆ…)
@tanstack/vue-query βˆ… <ΓΈ> (βˆ…)
@tanstack/vue-query-devtools βˆ… <ΓΈ> (βˆ…)

codecov[bot] avatar Aug 30 '24 22:08 codecov[bot]