query icon indicating copy to clipboard operation
query copied to clipboard

Update HydrationStreamProvider.tsx + Advanced SSR docs to fix unnecessary suspensions

Open mgreenw opened this issue 2 years ago β€’ 4 comments

This PR is based on my findings in #6116 and fixes two cases of unnecessary suspensions during streaming SSR, one on code and the other in the advanced SSR docs. See the full writeup in this comment, which should have all the info needed for reviewing this PR.

mgreenw avatar Jan 23 '24 03:01 mgreenw

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2024 8:25am

vercel[bot] avatar Jan 23 '24 03:01 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8955373c3d0f0ef5062bb325be4ca57c931d0d8:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Jan 23 '24 03:01 codesandbox-ci[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e8955373c3d0f0ef5062bb325be4ca57c931d0d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


βœ… Successfully ran 1 target

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] avatar Jan 27 '24 14:01 nx-cloud[bot]

@juliusmarminge would you mind taking a look here? Also I think the comment in the issue is super interesting:

  • https://github.com/TanStack/query/issues/6116#issuecomment-1904051005

TkDodo avatar Jan 27 '24 14:01 TkDodo

Codecov Report

Merging #6753 (c2d404b) into main (61f4d74) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6753   +/-   ##
=======================================
  Coverage   41.78%   41.78%           
=======================================
  Files         178      178           
  Lines        7014     7014           
  Branches     1416     1416           
=======================================
  Hits         2931     2931           
  Misses       3721     3721           
  Partials      362      362           
Components Coverage Ξ”
@tanstack/angular-query-devtools-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/angular-query-experimental 81.75% <ΓΈ> (ΓΈ)
@tanstack/eslint-plugin-query 85.11% <ΓΈ> (ΓΈ)
@tanstack/query-async-storage-persister 48.43% <ΓΈ> (ΓΈ)
@tanstack/query-broadcast-client-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/query-codemods 0.00% <ΓΈ> (ΓΈ)
@tanstack/query-core 93.62% <ΓΈ> (ΓΈ)
@tanstack/query-devtools 4.46% <ΓΈ> (ΓΈ)
@tanstack/query-persist-client-core 57.73% <ΓΈ> (ΓΈ)
@tanstack/query-sync-storage-persister 82.50% <ΓΈ> (ΓΈ)
@tanstack/react-query 93.07% <ΓΈ> (ΓΈ)
@tanstack/react-query-devtools 0.00% <ΓΈ> (ΓΈ)
@tanstack/react-query-next-experimental βˆ… <ΓΈ> (βˆ…)
@tanstack/react-query-persist-client 100.00% <ΓΈ> (ΓΈ)
@tanstack/solid-query 84.84% <ΓΈ> (ΓΈ)
@tanstack/solid-query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/solid-query-persist-client 100.00% <ΓΈ> (ΓΈ)
@tanstack/svelte-query 62.68% <ΓΈ> (ΓΈ)
@tanstack/svelte-query-devtools βˆ… <ΓΈ> (βˆ…)
@tanstack/svelte-query-persist-client 100.00% <ΓΈ> (ΓΈ)
@tanstack/vue-query 70.81% <ΓΈ> (ΓΈ)
@tanstack/vue-query-devtools βˆ… <ΓΈ> (βˆ…)

codecov-commenter avatar Feb 17 '24 18:02 codecov-commenter