query icon indicating copy to clipboard operation
query copied to clipboard

What about Svelte 5?

Open frederikhors opened this issue 2 years ago • 4 comments

After opening https://github.com/TanStack/query/discussions/6673 I thought it was time to consider the imminent arrival of Svelte 5.

All news are beautiful explained here: https://svelte-5-preview.vercel.app/docs/introduction.

How do we plan to do it?

I think we can finally close bug like:

  • https://github.com/TanStack/query/issues/5913
  • https://github.com/TanStack/query/issues/5855

frederikhors avatar Jan 10 '24 14:01 frederikhors

Everything in Query v5 should continue to work, since Svelte 5 is fully backwards compatible. A future Query version (v6?) will migrate from stores to runes.

lachlancollins avatar Jan 13 '24 11:01 lachlancollins

@lachlancollins is there an issue tracking the runes migration. It's been a huge pain working with derived queries with runes. Like a massive pain. It would be great to start a discussion on this. I feel like this issue works for that.

niemyjski avatar Jun 14 '24 16:06 niemyjski

@lachlancollins is there an issue tracking the runes migration. It's been a huge pain working with derived queries with runes. Like a massive pain. It would be great to start a discussion on this. I feel like this issue works for that.

Hi @niemyjski, see this PR: https://github.com/TanStack/query/pull/6981

lachlancollins avatar Jun 14 '24 22:06 lachlancollins

@lachlancollins I replied here wondering if it's the correct approach and what was left. https://github.com/TanStack/query/pull/6981#issuecomment-2121243912

niemyjski avatar Jun 18 '24 02:06 niemyjski

Hi @frederikhors , I've merged #6981 into https://github.com/TanStack/query/tree/svelte-5-adapter

It's still not ready for release, but I would appreciate more people giving it a try and contributing!

lachlancollins avatar Jul 26 '24 01:07 lachlancollins

We should probably continue discussion here: https://github.com/TanStack/query/discussions/7413

lachlancollins avatar Jul 26 '24 01:07 lachlancollins