form icon indicating copy to clipboard operation
form copied to clipboard

add effect-form-adapter

Open jessekelly881 opened this issue 1 year ago β€’ 7 comments

Adapted from zod-form-adapter.

https://github.com/Effect-TS/effect/tree/main/packages/schema

jessekelly881 avatar May 24 '24 19:05 jessekelly881

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c3b60b4f3fc88946fe83dc32bd4de3e7dbc73dd7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

πŸ“‚ See all runs for this CI Pipeline Execution


πŸŸ₯ Failed Commands
nx affected --targets=test:format,test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3

Sent with πŸ’Œ from NxCloud.

nx-cloud[bot] avatar May 28 '24 17:05 nx-cloud[bot]

I love this!! Thank you so much for making such a big contribution as your first time contributing!

Let's add docs + examples, then get this one merged in!

crutchcorn avatar May 28 '24 17:05 crutchcorn

Hey @jessekelly881 - wanted to check in on this. It's still marked as a draft PR, but otherwise LGTM. Is there anything we're waiting on prior to a review/merge?

crutchcorn avatar Jun 03 '24 06:06 crutchcorn

Hey @crutchcorn! At the moment it's missing an example for angular(I haven't used angular in a very long time and I am having some issues getting the examples running on my local for some reason.. :( ), a proper solution to the typeof schema === "function" issue I mentioned (the solution I have at the moment is incorrect sense function() {} is a "constructible" in js), I want to extend the createValidator api a little bit(there are other ways to create a validator that make sense) and probably docs but I'm not yet sure where the docs need updated yet.

jessekelly881 avatar Jun 03 '24 12:06 jessekelly881

Sounds good! Let me know if there's anything questions I can help answer with the local setup or anything of the nature ☺️

Keep up the great work!

crutchcorn avatar Jun 03 '24 12:06 crutchcorn

I'm currently running into this error with the angular examples(all of them). But the suggested solution of setting "preserveSymlinks" to true doesn't seem to work. https://github.com/angular/angular/issues/54147

jessekelly881 avatar Jun 03 '24 14:06 jessekelly881

@crutchcorn Wanna have another look? :)

jessekelly881 avatar Jun 07 '24 21:06 jessekelly881

Any updates on this, would love to see this merged.

izakfilmalter avatar Nov 08 '24 14:11 izakfilmalter

Sorry all, we've ultimately decided to axe custom validators that don't support Standard Schema. It was too high of a maintenance burden for us and most of the big libraries either already do or plan to support it in the future.

crutchcorn avatar Feb 21 '25 15:02 crutchcorn