TagStudioDev
fix: disable menu items and menubar class refactor
Fix for #692. Disables a list of menu options until a library is loaded and disables them again when the library is closed. Also moved the menu_bar into a separate class. Still need to rewrite some of the tests.
i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.
i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.
The refactor mentioned in the discord was in reference to #844 which was spun up and merged last week. That was a restructuring of the project layout to better align with a standard python src-layout structure, which corrected several issues we were having in the process.
Still, a refactor of ts_qt.py - most notably the separation of the now menu bar code, is still needed. The current driving force behind this is the need to refactor the Qt driver in a way that is easier to integrate with the tests. The general size of the file is a reason too, but the tests are the pressing issue. Because of this and my familiarity with the file I feel it would be best if I took on the task of splitting up the Qt driver myself.
i havent touched this since i opened it, but i heard in the discord that there is some refactoring happening! would definitely be interested in getting in on the action, ive noticed several similar refactorings that could be done throughout the project.
The refactor mentioned in the discord was in reference to #844 which was spun up and merged last week. That was a restructuring of the project layout to better align with a standard python src-layout structure, which corrected several issues we were having in the process.
Still, a refactor of ts_qt.py - most notably the separation of the now menu bar code, is still needed. The current driving force behind this is the need to refactor the Qt driver in a way that is easier to integrate with the tests. The general size of the file is a reason too, but the tests are the pressing issue. Because of this and my familiarity with the file I feel it would be best if I took on the task of splitting up the Qt driver myself.
There is also a lot of code duplication in the way the menu bar is built, so there is potential for improvements at that specific point as well.
Closing in favor of #935, as that PR refactored the menubar out of ts_qt.py