TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

More ways to open files

Open Tyrannicodin opened this issue 1 year ago • 7 comments

Adds both double click functionality to thumbnails in the thumbnail grid and an open files shortcut ctrl+shift+O.

Tyrannicodin avatar Sep 06 '24 00:09 Tyrannicodin

Double click makes sense, but Ctrl+Shift+O feels very unusual. Maybe it's because I'm on macOS where the convention is Cmd+ (ControlModifier + Key.Key_Down). Using this combo here would make it feel right.

yedpodtrzitko avatar Sep 09 '24 17:09 yedpodtrzitko

I was planning on using ctrl+o but that was the library open shortcut so added the Shift modifier, however that makes sense and I have now changed it.

Tyrannicodin avatar Sep 11 '24 14:09 Tyrannicodin

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

CyanVoxel avatar Sep 12 '24 00:09 CyanVoxel

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

on Windows it's just Enter, no?

yedpodtrzitko avatar Sep 12 '24 02:09 yedpodtrzitko

TIL that Command-Down Arrow opens the selected item in Finder. If there was an equivalent shortcut for Windows Explorer I would've recommended to use each on their respective platforms, but I can't seem to find one.

on Windows it's just Enter, no?

Apparently it is... So simple that Microsoft doesn't even consider it a "shortcut".

In this case I would recommend using the default behavior for each major OS's native file manager (macOS and Windows in this case, with a fallback on one for Linux unless someone can provide more information on that).

CyanVoxel avatar Sep 12 '24 02:09 CyanVoxel

The shortcut is now based on the main window, so can open multiple files at the same time. It now defaults to ctrl/cmd + Down or Enter on windows. Double click is now an actual double click instead of the way I did it before.

Tyrannicodin avatar Sep 16 '24 19:09 Tyrannicodin

please fix the pipeline, thanks.

yedpodtrzitko avatar Sep 19 '24 02:09 yedpodtrzitko

In this case I would recommend using the default behavior for each major OS's native file manager (macOS and Windows in this case, with a fallback on one for Linux unless someone can provide more information on that).

Linux file browsers work just like Windows, or at least every version of Ubuntu, Mint, and old versions of RedHat that I've used. The file browsers let you navigate with arrow keys, or by typing the name of the file, then you can just press enter to open what's selected. Or, double-click, of course.

roboticforest avatar Dec 10 '24 22:12 roboticforest

Thank you for your work on this! I apologize for not getting it pulled previously, I was anticipating the platform specific shortcuts to be changed in the background while tending to other high priority areas of the project.

What I've done now is port and update this functionality to a new PR (#858) with a co-author commit that brings over all of the changes added here along with the last bit of review feedback and updates to bring it up to the current codebase standards (translations, formatting, changed imports, etc.). I also have plans to extend some of the functionality here to other areas of the project, such as adding the double-click to the preview panel.

Thank you again for your previous work on this, and I hope you're doing well!

CyanVoxel avatar Mar 12 '25 07:03 CyanVoxel