TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

Autosave and Performance Settings

Open DrRetro2033 opened this issue 1 year ago • 2 comments

I was adding auto-saves to TagStudio when I realized, "We do not have any settings window!" So I created one. It is very simple and only contains three settings, one for auto-saving and minutes between each auto-save. I also added a Performance tab and added the option to not render thumbnails in the main view.

image Hope you like it :)

DrRetro2033 avatar May 09 '24 23:05 DrRetro2033

It feels like this PR is named improperly - the main part here are changes in functionality (autosave timer, rendering thumbnails switch). The settings window is nice -but complementary- thing in comparison.

As such, it would be better to create separate PR for each introduced feature (timer, rendering), so it can be tested in isolation.

Regarding the thumbnails rendering option - what is the use case to disable thumbnails rendering in -media library-? I mentioned previously that I dont like having all CPU cores busy with thumbnails rendering when the application starts, but this doesnt solve my use-case. I want to see the thumbnails, but only when I actually select the library I want. The more reasonable option I can imagine here would be option for number of threads which will be used for thumbnails rendering.

yedpodtrzitko avatar May 10 '24 02:05 yedpodtrzitko

It feels like this PR is named improperly - the main part here are changes in functionality (autosave timer, rendering thumbnails switch). The settings window is nice -but complementary- thing in comparison.

As such, it would be better to create separate PR for each introduced feature (timer, rendering), so it can be tested in isolation.

Regarding the thumbnails rendering option - what is the use case to disable thumbnails rendering in -media library-? I mentioned previously that I dont like having all CPU cores busy with thumbnails rendering when the application starts, but this doesnt solve my use-case. I want to see the thumbnails, but only when I actually select the library I want. The more reasonable option I can imagine here would be option for number of threads which will be used for thumbnails rendering.

A thread limit is amazing idea, I will add it. Also, I added "Do not Render Thumbnails" not because of your issue, but an issue I have been having with internet and storage performance. You see, some of my files on my computer are in the cloud because of OneDrive, and because TagStudio is opening them to get the thumbnails, all of those files get downloaded to my computer. This is just a band-aid for my issue, at least until we have a solution for online files.

DrRetro2033 avatar May 10 '24 14:05 DrRetro2033