TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

Video Player

Open DrRetro2033 opened this issue 1 year ago • 3 comments

https://youtu.be/sWr5EN5hRI8 Added a simple video player for Tag Studio. Currently, the player will automatically mute itself when switching to another video. This is by design, as playing a really loud video before someone is ready will probably cause heart-attacks.

Also, I noticed the big refactor, and I am not fully familiar with the structure. I currently have VideoPlayer imported like this. image Could someone tell me the correct way of importing my video player in preview_panel.py? Thanks!

DrRetro2033 avatar May 01 '24 01:05 DrRetro2033

I dont have strong opinion about the feature itself, and it's not up to me to decide, but the README mentions the code should follow pep-8. That means the camelCases names in code should rather be snake_cases.

yedpodtrzitko avatar May 01 '24 01:05 yedpodtrzitko

I dont have strong opinion about the feature itself, and it's not up to me to decide, but the README mentions the code should follow pep-8. That means the camelCases names in code should rather be snake_cases.

Alright, thanks for telling me.

DrRetro2033 avatar May 01 '24 01:05 DrRetro2033

Code review aside, I'm leaning towards a thumbnail with a play button on it being the default and then clicking it starting the preview but I'm open to what the community wants, I'd just be worried about responsiveness in remote storage cases which might not be the typical setup.

Loran425 avatar May 01 '24 02:05 Loran425