RustFFT.jl icon indicating copy to clipboard operation
RustFFT.jl copied to clipboard

Test Julia stable (currently 1.10.2)

Open mkitti opened this issue 1 year ago • 3 comments

This add Julia 1 to testing which currently will point to Julia 1.10.2

mkitti avatar Apr 23 '24 21:04 mkitti

I have no idea why the codecov action is failing on Linux, but at least the tests succeed now on 1.10.

Taaitaaiger avatar Apr 29 '24 20:04 Taaitaaiger

If you don't know how to solve the failing action either, I don't care about coverage that much FWIW. I think everything will work without any problems if

      - uses: julia-actions/julia-processcoverage@v1
      - uses: codecov/codecov-action@v1
        with:
          file: lcov.info

is removed.

Taaitaaiger avatar Apr 29 '24 21:04 Taaitaaiger

I think there are ways to adjust the codecov thresholds. I'll take a look later today.

mkitti avatar Apr 29 '24 23:04 mkitti

FWIW the coverage issue is no longer problematic.

CI is currently enabled for all supported versions of Julia. Since this package depends on a Julia-dependent JLL, I think it's best to test those specific versions rather than testing the current stable version specifically.

I don't think there's any further need to keep this PR open so I'm going to close it.

Taaitaaiger avatar Oct 14 '25 18:10 Taaitaaiger