protocols.distributed_keygen icon indicating copy to clipboard operation
protocols.distributed_keygen copied to clipboard
verified publisher icon TNO-MPC

Maybe a bug in function compute_modulus in Class DistributedPaillier

Open Jinstorm opened this issue 1 year ago • 3 comments

At https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1231, in Class DistributedPaillier class function compute_modulus . image Should it be shares.p = Shares.P(p_additive[i], prime_candidate_p[i].get_shares()) instead? To replace prime_candidate_q[i].get_share()

Jinstorm avatar Nov 04 '24 11:11 Jinstorm

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

Quitlox avatar Nov 04 '24 12:11 Quitlox

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

@Quitlox, you sure about that? https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1344C1-L1345C84

Still seems broken in latest.

ThomasTNO avatar Dec 10 '24 13:12 ThomasTNO

Well spotted, this is indeed a mistake. It's already been resolved in a new version that is currently in the works :)

@Quitlox, you sure about that? https://github.com/TNO-MPC/protocols.distributed_keygen/blob/main/src/tno/mpc/protocols/distributed_keygen/distributed_keygen.py#L1344C1-L1345C84

Still seems broken in latest.

Not that version unfortunately, it's still in the works.

Quitlox avatar Dec 10 '24 14:12 Quitlox