ArchUnitNET icon indicating copy to clipboard operation
ArchUnitNET copied to clipboard

Add MSTestV4 Support

Open SeMuell opened this issue 3 months ago • 4 comments

This PR introduces support for the latest MSTest version (4.0) to fix the file not found issue in #424.

Since the MSTestV2 package was also compatible with MSTestV3, I added another test project to have proper testing.

However, maybe there is a better, future-proof way for the implementation I haven't found yet in comparison to the naive approach, I'll keep digging.

SeMuell avatar Oct 16 '25 16:10 SeMuell

Having a loosely coupled dependency like FluentAssertions to 'Microsoft.VisualStudio.TestTools.UnitTesting.AssertFailedException' with reflection would also work here. Doing this the direct dependency on the TestFramework could be removed and may be more future proof (maybe reasonable doing the same for the other projects). What do you think?

SeMuell avatar Oct 17 '25 13:10 SeMuell

Hey, please review and finish this PR. This prevents upgrade to the latest MSTest.SDK.

mlautin avatar Dec 09 '25 06:12 mlautin

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 73.79%. Comparing base (4006980) to head (1f9054d). :warning: Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
- Coverage   74.84%   73.79%   -1.06%     
==========================================
  Files         257      259       +2     
  Lines       17221    16387     -834     
  Branches     1575     1336     -239     
==========================================
- Hits        12889    12092     -797     
- Misses       3876     3878       +2     
+ Partials      456      417      -39     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 10 '25 17:12 codecov-commenter

@SeMuell, I unfortunately was missing a setting to require sign-off on web-based commits. So you'd have to add a sign-off on the last commit manually. Also, please update your branch with main and make sure the formatting is correct. Then I'll be able to merge and release a new version

alexanderlinne avatar Dec 14 '25 10:12 alexanderlinne

Unfortunately, I am currently on vacation without access to a laptop. However, I'll try to manage it in the next two days.

SeMuell avatar Dec 17 '25 13:12 SeMuell