Custom create parameters in room type settings

[dennis531]

Fixes #559

Type (Highlight the corresponding type)

• Bugfix
• Feature
• Documentation
• Refactoring (e.g. Style updates, Test implementation, etc.)
• Other (please describe):

Checklist

• [x] Code updated to current masters head
• [x] Passes CI checks
• [x] Is a part of an issue
• [ ] Tests added for the bugfix or newly implemented feature, describe below why if not
• [x] Changelog is updated
• [ ] Documentation of code and features exists

Changes

• Adds custom create api call parameters in room type settings
• Room settings will be changed according to the custom parameters when the room type is changed.

Other information

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.86%. Comparing base (372f4cd) to head (ead5e0b).

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #574      +/-   ##
=============================================
+ Coverage      95.82%   95.86%   +0.03%     
- Complexity      1288     1295       +7     
=============================================
  Files            198      198              
  Lines           4412     4430      +18     
=============================================
+ Hits            4228     4247      +19     
+ Misses           184      183       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[samuelwei]

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.

https://github.com/THM-Health/PILOS/assets/4281791/dcf91ae7-2763-4108-af20-1a907274f2c6

[samuelwei]

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue.

2023-09-19.17-06-27.mp4

Looks like this bug already exists

[dennis531]

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue. 2023-09-19.17-06-27.mp4

Looks like this bug already exists

I would suggest to resolve this issue in a separate pull request.

I continue trying to fix the listed errors in the PHP checks.

[dennis531]

I'm not sure whether it's a CI configuration issue or a problem caused by the changes in this pull request. My guess is the former.

[samuelwei]

@dennis531 I'll have a look

[samuelwei]

If the room type settings are changed in the meantime, the room type is always 'reset'. Only refreshing the list solves this issue. 2023-09-19.17-06-27.mp4

Looks like this bug already exists

I would suggest to resolve this issue in a separate pull request.

I continue trying to fix the listed errors in the PHP checks.

@dennis531 I fixed the issue

[tibroc]

@SamuelWei what does this need need now to be merged?

[samuelwei]

@SamuelWei what does this need need now to be merged?

@tibroc Frontend and backend tests; if I havn't missed it, the custom params are shown in the UI once the type is changed, but they should also be applied on creating a new room with this type; to improve the UX it might also be good to show the user what settings will be changed, giving the user to option to accept oder dismiss the changes.

[samuelwei]

@dennis531 @tibroc We are currently working on something similar in https://github.com/THM-Health/PILOS/tree/695-restructure-room-settings-page

As soon as this is finished, we will have an other look at this PR and see how we can integrate this