CTFNote icon indicating copy to clipboard operation
CTFNote copied to clipboard
verified publisher icon TFNS

Feature: iCal link

Open JJ-8 opened this issue 2 years ago • 2 comments

This is a successor PR of https://github.com/TFNS/CTFNote/pull/146. I modified two things:

  1. The UI for getting the link is changed: now you just click the button and the link is copied to your clipboard, confirmed with a checkmark.
  2. The URL in the iCal is the URL for the CTF itself, not the link from CTFNote (as stated in https://github.com/TFNS/CTFNote/pull/146#issuecomment-1056452392).

Please note that this PR can NOT be merged before https://github.com/TFNS/CTFNote/pull/214 is merged because of the order of the migrations.

JJ-8 avatar May 09 '23 08:05 JJ-8

There were some merge conflicts with the yarn.lock files due to the new ical dependency. I have resolved them by removing the yarn.lock and running yarn again. This resulted in quite a big dependency update. I did a quick manual test of all the features and everything appears to still work fine.

JJ-8 avatar May 09 '23 08:05 JJ-8

@XeR Can you have a look please? ❤️ We'd like to use this feature!

peace-maker avatar Jul 28 '23 09:07 peace-maker

This is already included in https://github.com/TFNS/CTFNote/pull/237

JJ-8 avatar Apr 28 '24 14:04 JJ-8