teammates icon indicating copy to clipboard operation
teammates copied to clipboard

[#11950] Fix bug with overflow of members count in error message

Open domlimm opened this issue 3 years ago • 4 comments

Fixes #11950.

Outline of Solution

Previously, the zero-sum contribution question overflows when it exceeds the total required contribution percentage i.e. Number of members in the team * 100%, as it is not captured in the logic flow for the error message.

image

Now, we have introduced another way of checking for this overflow and reducing the number of Equal Share with a cap based on the number of members in a team by Total required contribution percentage / 100. The excess will then be calculated separately.

And now, it should read Current total 5 x Equal share + 100% ... when the total required contribution percentage exceeds n * 100, where n is the number of members.

image

domlimm avatar Sep 04 '22 15:09 domlimm

Hello @zhaojj2209, thank you for your review and catching that! Have rolled out the change 👍🏻

domlimm avatar Sep 06 '22 10:09 domlimm

@NicolasCwy Kindly for your attention.

ziqing26 avatar Sep 07 '22 13:09 ziqing26

Guys, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Sep 14 '22 14:09 nusoss-bot

Guys, This PR seems to be stalling (no activities for the past 7 days). :snail: :cry: Hope someone can get it to move forward again soon...

nusoss-bot avatar Sep 21 '22 14:09 nusoss-bot