fceux icon indicating copy to clipboard operation
fceux copied to clipboard

[Qt] hex editor changes revert after reset

Open ClusterM opened this issue 3 years ago • 2 comments

Describe the bug If you open hex editor, made some changes and reset game to see changes - all changes will be reverted.

To Reproduce Steps to reproduce the behavior:

  1. Open any ROM
  2. Open Hex Editor
  3. Change something
  4. Reset game (Ctrl+R)
  5. All changes are missed now

Expected behavior I want to see my changes after reset, like on the Win64 version.

(please complete the following information):

  • Kubuntu Linux
  • QT, b912004f69c7a7ace4b709658c54340466fc1070

ClusterM avatar May 18 '22 10:05 ClusterM

why did you assign and unassign these, to get my attention?

zeromus avatar May 28 '22 22:05 zeromus

why did you assign and unassign these, to get my attention?

Just misclicked, sorry.

ClusterM avatar May 29 '22 00:05 ClusterM

Changed Ctrl+R mapping so that it only runs a soft reset (which should keep changes). Hard reset is now mapped to Ctrl+Shift+R. Please try latest dev build and provide feedback.

thor2016 avatar Aug 23 '22 22:08 thor2016

ctrl+r seems to be a soft reset on the win32 version so this was probably the right way to go.

zeromus avatar Aug 23 '22 23:08 zeromus

I was able to come up with a good test case for this. Seems to work fine to me. I'm going to close this. Feel free to reopen if unsatisfactory.

thor2016 avatar Sep 02 '22 01:09 thor2016