Better Firmware Names
Renaming Firmware Files based on System Name as BizHawk uses or at least renamed to be related to what it's for.
This changes the Auto-Renamed Firmware Files to be named based on the System ID. Or to be more Descriptive. So the users can see helpful file names.
The File has been formatted to use LF instead of CRLF. Which is why it feels like a "Full Replacement"
Examples of Old Name: cx4.rom KoF95.bin
Examples of New Name: SNES_cx4.rom SAT_KoF95.bin
Also changed the MSX 1.0 BIOS and BASIC vs MSX BIOS and BASIC have their own filenames now instead of a Filename Collision.
Check if completed:
- [X] I have run any relevant test suites
- [X] I, the committer, have read the licensing terms for contributors (last updated 2022-07-15) and am compliant
The File has been formatted to use LF instead of CRLF.
IMO good, but don't include unrelated changes in your PR. With -w, I can immediately see a typo, and it looks like you've reordered all the sections. If you're going to do that, can you make it a separate commit? No-one can review this as-is.
I do not get why the Commit I made is changing the Line Endings. But I have redone the changes. They are: PC-Engine, Vectrex, Lynx, MSX And resolve Name Collision, Odyssey 2 G7400, Gameboy, GameBoy Color.
That unifies the names for all the Firmware.
I'd forgotten about #2204, but this is a follow-up to that.
I don't have an opinion on cosmetic changes changes that don't change UX.
Okay, unless there's any further disagreement I'll just merge this later then; I've resolved the previous review comments myself.