SysML-v2-Release icon indicating copy to clipboard operation
SysML-v2-Release copied to clipboard

Incorrect syntax in example OR incorrect grammar in KerML

Open dhakehurst opened this issue 2 years ago • 3 comments

Example [Vehicle Example/VehicleDefinitions.kerml]

package VehicleDefinitions {
	doc
	/*
	 * Example vehicle definitions model.
	 */

	
	/* BLOCKS */
     ^^^^
	class Vehicle;	
	class Transmission;	

either a grammar issue and 'doc' element should be allowed multiple REGULAR_COMMENT's in it

OR

in this example\* BLOCKS *\ (and others later in example) should be a MULTILINE_NOTE not a REGULAR_COMMENT

not sure why your own tests are not showing this up ?

dhakehurst avatar Oct 04 '23 09:10 dhakehurst

this might be a mistake in the standard grammar where comment is defined as

Comment =
  'comment' Identification
  (  'about'  Annotation ( ',' Annotation )*  )?
 REGULAR_COMMENT

where as the pilot implementation XText specifies

Comment returns SysML::Comment :
	( 'comment' Identification?  ('about'  Annotation  ( ',' Annotation )* )?  )?
	REGULAR_COMMENT
;

dhakehurst avatar Oct 04 '23 09:10 dhakehurst

This does, indeed, look like an error in the KerML Specification document. Please submit this as an issue at https://issues.omg.org/issues/create-new-issue.

seidewitz avatar Oct 04 '23 10:10 seidewitz

done

dhakehurst avatar Oct 04 '23 14:10 dhakehurst

This has been fixed.

seidewitz avatar Nov 27 '24 06:11 seidewitz