White-box-Cartoonization icon indicating copy to clipboard operation
White-box-Cartoonization copied to clipboard

about adaptive coloring algorithm and structure representation

Open JKANG94 opened this issue 5 years ago • 3 comments

In train.py, I found that the structure loss is not built with adaptive coloring algorithm. It is same as the content loss. So why didn't use adaptive coloring algorithm?

JKANG94 avatar Sep 19 '20 02:09 JKANG94

The random color shift algorithm also is not the same as the paper described.

JKANG94 avatar Sep 19 '20 02:09 JKANG94

@JKANG94 I am quite sure that the random color shift is the same as the paper described, it was implemented in another format, but these are mathmatically equaivalent. For adaptive coloring, as I have mentioned, it was not stable and easily causes pixel overflow. Still, you can try to use it by using pixel normalization and adding a tanh layer in the generator. I believe these have been implemented though unused.

SystemErrorWang avatar Sep 19 '20 04:09 SystemErrorWang

clipping and tanh may help, but they don't solve the issue at all. You can make it solid though, you just have to plug in a couple work arounds to the math functions that will break due to inputs.

markrmiller avatar Oct 31 '22 02:10 markrmiller