PHP_XLSXWriter_plus icon indicating copy to clipboard operation
PHP_XLSXWriter_plus copied to clipboard

Wrong variable

Open davellanedam opened this issue 11 years ago • 1 comments

Hi SystemDevil, i used your implementation, and it´s perfect!, but i´ve found on lines 227 and 229, that you call $cell_format which should be $value to work ok.

} else if ($cell_format=='date') {

Should be

} else if ($value=='date') {

Apart from that it´s working really good, again, million thanks for sharing!

davellanedam avatar May 12 '14 20:05 davellanedam

Also there is a default value missing of the function

Line 119

public function writeSheet(array $data, $sheet_name='', array $header_types=array(), array $styles)

should be

public function writeSheet(array $data, $sheet_name='', array $header_types=array(), array $styles=array())

or you lose the ability to use simple declaration like $writer->writeSheet($result) when doing a simple write.

smiffy6969 avatar Nov 12 '14 11:11 smiffy6969