[Bug] composer.json missing constraints
SyliusPayPalPlugin version affected: ^1.7.1
Description
The dependencies in composer.json are not defined correctly. Below is an example with version 1.7.2:
Sylius PayPal supports sylius/sylius (~1.13.0 || ~1.14.0). This means that the PayPal plugin would support Sylius with version 1.13.4. Sylius version 1.13.4 supports the sylius/resource-bundle (^1.9).
However, PayPal version 1.7.2 uses interfaces (FactoryInterface) that are only available in the Resource Bundle version 1.11 and higher.
This combination is therefore compatible according to composer.json:
- Sylius: 1.13.4
- Resource Bundle: 1.10
- PayPal: 1.7.2
In reality, however, these are not compatible and Sylius will crash completely after the composer update.
https://github.com/Sylius/PayPalPlugin/commit/6b6c8c311dacc37fbfd139d7329567e689b7154c#diff-263ae2245b1db1de371c2f7433ae213990d681dee310283366eeadba998f5568R21-R38
Steps to reproduce
- Install with given versions
Possible Solution
- Add Resource Bundle with version ^1.11 as dependency or support version ^1.9
Hi, i have the same issue when i try to update to Sylius 1.13
Hi, I have the same issue here too !
Hi! I'm closing this issue as it seems to be resolved by https://github.com/Sylius/PayPalPlugin/pull/382 🎉